-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Support remote cache CDC #28437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tyler-french
wants to merge
1
commit into
bazelbuild:master
from
tyler-french:tfrench/chunked-remote-cache
Closed
Support remote cache CDC #28437
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
src/main/java/com/google/devtools/build/lib/remote/ChunkedBlobDownloader.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| // Copyright 2026 The Bazel Authors. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.devtools.build.lib.remote; | ||
|
|
||
| import static com.google.devtools.build.lib.remote.util.Utils.getFromFuture; | ||
|
|
||
| import build.bazel.remote.execution.v2.Digest; | ||
| import build.bazel.remote.execution.v2.SplitBlobResponse; | ||
| import com.google.common.util.concurrent.ListenableFuture; | ||
| import com.google.devtools.build.lib.remote.common.CacheNotFoundException; | ||
| import com.google.devtools.build.lib.remote.common.RemoteActionExecutionContext; | ||
| import java.io.IOException; | ||
| import java.io.OutputStream; | ||
| import java.util.List; | ||
|
|
||
| /** | ||
| * Downloads blobs by sequentially fetching chunks via the SplitBlob API. | ||
| */ | ||
| public class ChunkedBlobDownloader { | ||
| private final GrpcCacheClient grpcCacheClient; | ||
| private final CombinedCache combinedCache; | ||
|
|
||
| public ChunkedBlobDownloader(GrpcCacheClient grpcCacheClient, CombinedCache combinedCache) { | ||
| this.grpcCacheClient = grpcCacheClient; | ||
| this.combinedCache = combinedCache; | ||
| } | ||
|
|
||
| /** | ||
| * Downloads a blob using chunked download via the SplitBlob API. This should be called with | ||
| * virtual threads, as it blocks on futures via {@link | ||
| * com.google.devtools.build.lib.remote.util.Utils#getFromFuture}. | ||
| */ | ||
| public void downloadChunked( | ||
| RemoteActionExecutionContext context, Digest blobDigest, OutputStream out) | ||
| throws IOException, InterruptedException { | ||
| List<Digest> chunkDigests = getChunkDigests(context, blobDigest); | ||
| downloadAndReassembleChunks(context, chunkDigests, out); | ||
| } | ||
|
|
||
| private List<Digest> getChunkDigests( | ||
| RemoteActionExecutionContext context, Digest blobDigest) | ||
| throws IOException, InterruptedException { | ||
| if (blobDigest.getSizeBytes() == 0) { | ||
| return List.of(); | ||
| } | ||
| ListenableFuture<SplitBlobResponse> splitResponseFuture = | ||
| grpcCacheClient.splitBlob(context, blobDigest); | ||
| if (splitResponseFuture == null) { | ||
| throw new CacheNotFoundException(blobDigest); | ||
| } | ||
| List<Digest> chunkDigests = getFromFuture(splitResponseFuture).getChunkDigestsList(); | ||
| if (chunkDigests.isEmpty()) { | ||
| throw new CacheNotFoundException(blobDigest); | ||
| } | ||
| return chunkDigests; | ||
| } | ||
|
|
||
| private void downloadAndReassembleChunks( | ||
| RemoteActionExecutionContext context, List<Digest> chunkDigests, OutputStream out) | ||
| throws IOException, InterruptedException { | ||
| for (Digest chunkDigest : chunkDigests) { | ||
| getFromFuture(combinedCache.downloadBlob(context, chunkDigest, out)); | ||
| } | ||
| } | ||
| } | ||
121 changes: 121 additions & 0 deletions
121
src/main/java/com/google/devtools/build/lib/remote/ChunkedBlobUploader.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| // Copyright 2026 The Bazel Authors. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.devtools.build.lib.remote; | ||
|
|
||
| import static com.google.devtools.build.lib.remote.util.Utils.getFromFuture; | ||
|
|
||
| import build.bazel.remote.execution.v2.Digest; | ||
| import com.google.common.collect.ImmutableSet; | ||
| import com.google.common.io.ByteStreams; | ||
| import com.google.devtools.build.lib.remote.chunking.ChunkingConfig; | ||
| import com.google.devtools.build.lib.remote.chunking.FastCDCChunker; | ||
| import com.google.devtools.build.lib.remote.common.RemoteActionExecutionContext; | ||
| import com.google.devtools.build.lib.remote.util.DigestUtil; | ||
| import com.google.devtools.build.lib.vfs.Path; | ||
| import com.google.protobuf.ByteString; | ||
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
| import java.util.HashSet; | ||
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| /** | ||
| * Uploads blobs in chunks using Content-Defined Chunking with FastCDC 2020. | ||
| * | ||
| * <p> | ||
| * Upload flow for blobs above threshold: | ||
| * | ||
| * <ol> | ||
| * <li>Chunk file with FastCDC | ||
| * <li>Call findMissingDigests on chunk digests | ||
| * <li>Upload only missing chunks | ||
| * <li>Call SpliceBlob to register the blob as the concatenation of chunks | ||
| * </ol> | ||
| */ | ||
| public class ChunkedBlobUploader { | ||
|
tyler-french marked this conversation as resolved.
|
||
|
|
||
| private final GrpcCacheClient grpcCacheClient; | ||
| private final CombinedCache combinedCache; | ||
| private final FastCDCChunker chunker; | ||
| private final long chunkingThreshold; | ||
|
|
||
| /** | ||
| * Creates a new uploader with the given chunking configuration. | ||
| * | ||
| * @param grpcCacheClient client used for {@code FindMissingDigests} and {@code SpliceBlob} RPCs | ||
| * @param combinedCache cache used to upload individual chunks | ||
| * @param config chunking parameters negotiated from server capabilities | ||
| * @param digestUtil utility for computing chunk digests | ||
| */ | ||
| public ChunkedBlobUploader( | ||
| GrpcCacheClient grpcCacheClient, | ||
| CombinedCache combinedCache, | ||
| ChunkingConfig config, | ||
| DigestUtil digestUtil) { | ||
| this.grpcCacheClient = grpcCacheClient; | ||
| this.combinedCache = combinedCache; | ||
| this.chunker = new FastCDCChunker(config, digestUtil); | ||
| this.chunkingThreshold = config.chunkingThreshold(); | ||
| } | ||
|
|
||
| /** Returns the minimum blob size for chunked upload. */ | ||
| public long getChunkingThreshold() { | ||
| return chunkingThreshold; | ||
| } | ||
|
|
||
| /** | ||
| * Uploads a blob in content-defined chunks. The file is chunked with FastCDC, missing chunks are | ||
| * uploaded, and {@code SpliceBlob} is called to register the blob as the concatenation of its | ||
| * chunks. | ||
| */ | ||
| public void uploadChunked(RemoteActionExecutionContext context, Digest blobDigest, Path file) | ||
| throws IOException, InterruptedException { | ||
| List<Digest> chunkDigests; | ||
| try (InputStream input = file.getInputStream()) { | ||
| chunkDigests = chunker.chunkToDigests(input); | ||
| } | ||
| if (chunkDigests.isEmpty()) { | ||
| return; | ||
| } | ||
|
|
||
| ImmutableSet<Digest> missingDigests = getFromFuture(grpcCacheClient.findMissingDigests(context, chunkDigests)); | ||
| uploadMissingChunks(context, missingDigests, chunkDigests, file); | ||
| getFromFuture(grpcCacheClient.spliceBlob(context, blobDigest, chunkDigests)); | ||
| } | ||
|
tyler-french marked this conversation as resolved.
|
||
|
|
||
| private void uploadMissingChunks( | ||
| RemoteActionExecutionContext context, | ||
| ImmutableSet<Digest> missingDigests, | ||
| List<Digest> chunkDigests, | ||
| Path file) | ||
| throws IOException, InterruptedException { | ||
| if (missingDigests.isEmpty()) { | ||
| return; | ||
| } | ||
|
|
||
| Set<Digest> uploaded = new HashSet<>(); | ||
| try (InputStream input = file.getInputStream()) { | ||
| for (Digest chunkDigest : chunkDigests) { | ||
| if (missingDigests.contains(chunkDigest) && uploaded.add(chunkDigest)) { | ||
| ByteString.Output out = ByteString.newOutput((int) chunkDigest.getSizeBytes()); | ||
| ByteStreams.limit(input, chunkDigest.getSizeBytes()).transferTo(out); | ||
| getFromFuture(combinedCache.uploadBlob(context, chunkDigest, out.toByteString())); | ||
| } else { | ||
| input.skipNBytes(chunkDigest.getSizeBytes()); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.