fix: restore missing release binaries#1254
Merged
jbedard merged 1 commit intobazel-contrib:mainfrom Apr 29, 2026
Merged
Conversation
kormide
approved these changes
Apr 29, 2026
kormide
reviewed
Apr 29, 2026
The release process seems to have broken due to this bug in download-artifact: actions/download-artifact#455 We use the release_ruleset.yaml reusable workflow, which downloads all artifacts [here](https://github.com/bazel-contrib/.github/blob/af28703814cf26522cf5e44d219efece91293123/.github/workflows/release_ruleset.yaml#L103). But since there is only one artifact (`go-binaries.zip`), we hit that bug which causes the binaries to appear directly in the working directory instead of in `./go-binaries`. This change fixes the problem by nesting everything inside a `go-binaries` directory inside `go-binaries.zip`. This way when the file is unzipped, all the binaries appear to be in the same place they were before.
jbedard
approved these changes
Apr 29, 2026
Collaborator
|
FYI @alexeagle @fmeum this was introduced in #1249 and caused the 3.3.0 release to not have the artifacts in it |
acozzette
changed the title
fmeum
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release process seems to have broken due to this bug in download-artifact: actions/download-artifact#455 We use the release_ruleset.yaml reusable workflow, which downloads all artifacts here. But since there is only one artifact (
go-binaries.zip), we hit that bug which causes the binaries to appear directly in the working directory instead of in./go-binaries.This change fixes the problem by nesting everything inside a
go-binariesdirectory insidego-binaries.zip. This way when the file is unzipped, all the binaries appear to be in the same place they were before.