feat: add repo_utils.arch() and use rctx.os.arch where available.#1253
Open
mattyclarkson wants to merge 3 commits intobazel-contrib:mainfrom
Open
feat: add repo_utils.arch() and use rctx.os.arch where available.#1253mattyclarkson wants to merge 3 commits intobazel-contrib:mainfrom
repo_utils.arch() and use rctx.os.arch where available.#1253mattyclarkson wants to merge 3 commits intobazel-contrib:mainfrom
Conversation
mattyclarkson
changed the title
repo_utils.arch() and use rctx.os.arch where available.repo_utils.arch() and use rctx.os.arch where available.
Provides the host CPU architecture. Previously available within `repo_utils.platform()`, now an explicit function. Review-by: Matthew Clarkson <matthew.clarkson@arm.com> # gatekeeper
Review-by: Matthew Clarkson <matthew.clarkson@arm.com> # gatekeeper
Available in Bazel 5.1.1+, it exposes the JVM `os.arch` string as lower case. When available this allows avoiding execution of `uname`. There _could_ be a possibility of `rctx.os.arch` not aligning with `uname -m` in all cases. For the common CPU architectures, it does. If there are cases where it diverges, new aliases can be added to align. Review-by: Matthew Clarkson <matthew.clarkson@arm.com> # gatekeeper
mattyclarkson
force-pushed
the
repo-utils-arch
branch
from
2c12a85 to
60f67d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch failing
unameexecutions rather than returning empty strings.