Always draw the sensor layer on the control view - #178
Merged
Merged
Conversation
The "Sensors" checkbox (#76) shipped off by default: the layer was framed as a diagnostic an operator reaches for when chasing a flaky beam. In use it is wanted on every visit, and an operator has to remember to switch it on every visit — which means it is off precisely when something unexpected happens. Withdraws the checkbox and `buildLiveDiagramState`'s `showSensors` parameter, and mounts the sensor key permanently alongside the layer it explains. D8's actual decision is untouched: the beam keeps its own subordinate channel, four states, never a block tint and never a share of the occupancy fill. What changes is only whether it is drawn. Recorded as `docs/diagram-encoding.md` D9. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The sensor layer on the control view is now always drawn. The "Sensors" checkbox is gone,
and so is
buildLiveDiagramState'sshowSensorsparameter. The sensor key is mountedpermanently beside the layer it explains.
Why
#76 shipped the layer off by default, reasoning that raw sensor evidence and derived block
occupancy can legitimately disagree (
deriveBlockOccupancyclause 3), so defaulting it onwould make that disagreement the first thing a new operator sees.
That property is real and unchanged — but it argues for the subordinate mark, which D8
also decided and which stands. It does not argue for hiding the mark. In practice the beams
are wanted on every visit to the tab and have to be switched on every visit, so the layer is
off exactly when something unexpected happens. It also runs against #28's own rule that an
untrusted reading is shown, never hidden: a default-off layer applies the opposite rule to
every reading at once.
What is unchanged
D8's encoding decision in full: the beam keeps its own channel, four states
(
occupied/clear/not-evidence/no-reading), a smaller and visibly differentmark, never a share of
OCCUPANCY's fill and never a fifth block tint. D4's four validatedtints are untouched. The Track Editor still draws no sensor observation — it passes no live
state at all.
Recorded as
docs/diagram-encoding.mdD9, with a pointer from D8.docs/current-state.md,README.mdand the CLAUDE.md index line move with it.Verification
Run in this session, from the repo root:
npm run lint— cleannpm test— backend 84 files / 1497 tests passed; frontend 27 files / 327 tests passednpm run test:e2e— 71 passed, including the rewrittentests/e2e/control-view.spec.tscase, which now asserts the beam title is present onload and that no "Sensors" checkbox exists
🤖 Generated with Claude Code