Repository navigation
Switch board 1 to the active-high bazauto detector (#9) - #27
Merged
Merged
Conversation
The LM-iD.1 on Goods Shed is removed. Every cs--- entry now uses BAZAUTO_BD_ACTIVE_LOW, so a broken signal wire reads occupied. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LM-iD.1 on Goods Shed has been removed. Board 1 (
0x20) is now allbazauto/block-detectionboards, so everycs---entry inSENSORSmoves fromLM_ID_ACTIVE_LOWtoBAZAUTO_BD_ACTIVE_LOW(active high).The detectors run push-pull at 3.3 V, so a broken signal wire now reads occupied against the expander's pull-up rather than
clear. That fixes the board 1 half of #9. Board 2's IR is untouched and stays active low.Only
cs---goods-shedis inINSTALLED. The other eight detectors aren't connected yet and stay silent until each one is added. They already carry the right polarity, so bringing one online only means adding its id.LM_ID_ACTIVE_LOWis kept but no entry uses it. Refitting an LM-iD is then a visible one-line change, anddocs/block-detector-wiring.mdis kept for the 5 V Input A hazard.Tests
test_the_installed_sensors_are_active_lowbecomestest_the_installed_sensors_have_their_devices_polarity: Goods Shed's detector is active high and its beam is active low.test_every_current_sensor_uses_the_bazauto_detector_polarity: acs---entry left on the old polarity would read backwards once installed.python -m pytest: 208 passed.Deployed
Deployed to the io-node Pico with
scripts/deploy.sh io-node(orchestrator/healthonline, manual mode). The broker afterwards showedcs---goods-shed→occupiedandir---goods-shed→clear, re-asserted.Docs
CLAUDE.md,README.md,docs/pin-allocation.mdanddocs/block-detector-wiring.mdnow describe board 1 as active high and the LM-iD.1 as retired.Refs #9. The supply and ground wire-pull checks there are still to be recorded.
🤖 Generated with Claude Code