[upstream candidate] Guard v_nom voltage floor on line-less (Zonal) networks - #5
Open
mark-hammond wants to merge 1 commit into
Open
[upstream candidate] Guard v_nom voltage floor on line-less (Zonal) networks#5mark-hammond wants to merge 1 commit into
mark-hammond wants to merge 1 commit into
Conversation
apply_*_overrides indexes network.lines['v_nom'] when min_bm_constraint_voltage_kv > 0, but the Zonal network models inter-zone links and has no lines / no 'v_nom' column, so the solve raises KeyError. Skip the voltage floor when there are no lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging PR on our fork (not yet sent to andrewlyden). The voltage-floor block indexes network.lines['v_nom'] when min_bm_constraint_voltage_kv > 0, but the Zonal network has no lines/no v_nom column -> KeyError. Skip when there are no lines.