[upstream candidate] Fix enrich_locations float64/str dtype TypeError - #4
Open
mark-hammond wants to merge 1 commit into
Open
[upstream candidate] Fix enrich_locations float64/str dtype TypeError#4mark-hammond wants to merge 1 commit into
mark-hammond wants to merge 1 commit into
Conversation
The new string columns (gb_region, location_source, coordinate_quality, location_notes, ...) were initialised as np.nan (float64), so assigning a real string later raises 'TypeError: Invalid value for dtype float64' under strict pandas (>=2.x) on a fresh run. Initialise string columns as object dtype; numeric lat/lon columns stay float.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging PR on our fork (not yet sent to andrewlyden). String enrichment columns were initialised as float64 np.nan, raising a TypeError when a string is assigned under strict pandas. Initialise string columns as object dtype; lat/lon stay float.