Skip to content

[upstream candidate] Fix cp1252 DUKES failures-cache read #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mark-hammond wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[upstream candidate] Fix cp1252 DUKES failures-cache read #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/generators/DUKES_generator_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,10 @@ def geocode_from_nominatim(df: pd.DataFrame, cache_file: str = "data/generators/
# Load failure cache (stations that couldn't be geocoded)
failed_stations = set()
if Path(failure_cache_file).exists():
with open(failure_cache_file, 'r') as f:
# The failures cache ships cp1252-encoded (Windows origin; e.g. the apostrophe
# in "Fiddler's Ferry"), which raises UnicodeDecodeError under the default UTF-8
# reader on macOS/Linux. Read it as cp1252 and tolerate stray bytes.
with open(failure_cache_file, 'r', encoding='cp1252', errors='ignore') as f:
failed_stations = set(line.strip() for line in f if line.strip())
logger.info(f"Loaded {len(failed_stations)} previously failed stations from cache")

Expand Down