Repository navigation
fix: recognize renamed formulas, trim trailing whitespace (v1.0.1) - #7
Merged
Merged
Conversation
- `brew list` shows the name a formula was installed under, brew info the current one: sdl2 (now sdl2-compat) had no description and, worse, was shown as installed by the user although it is a dependency. Map aliases and old names to the formula's data, with both JSON parsers. - rows without a description no longer end in padding whitespace - "1 dependency hidden" instead of "1 dependencies hidden" - categorize actionlint, shellcheck (Development) and brewshelf (CLI Tools) - version 1.0.1 - tests: aliases, old names, trailing whitespace, dependency label without description (66 checks)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by running the installed 1.0.0 on a real machine.
Bug: renamed formulas
sdl2was renamed tosdl2-compatin Homebrew.brew liststill shows the name it was installed under, whilebrew info --jsonuses the new name and keeps the old one inaliases/oldnames. brewshelf couldn't match them:ffmpeg)Fix: every formula also gets a row for each alias and old name, with both the
jqand theosascriptparser.Small fixes
--all, there are now 0 lines with trailing whitespace. All rows go through oneprint_rowhelper.actionlint,shellcheck→ Development,brewshelf→ CLI Tools. The real machine now has no "Other" section.BREWSHELF_VERSION→ 1.0.1.Tests (66 checks, was 59)
Aliases (hidden + described), old names, trailing whitespace, dependency label without description, alias resolution with both parsers.
After merge
Tag
v1.0.1, create the GitHub release, and updateurl/sha256inbatuhan-bas/homebrew-tap.