fix: prevent black Metal terminal frames#1129
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
With Metal enabled, SwiftTerm returns early from the outer LocalProcessTerminalView draw path because a nested MTKView owns presentation. Pine still called setNeedsDisplay and displayIfNeeded on the outer view, so recovery redraws could be no-ops. A freshly attached CAMetalLayer may also temporarily have no currentDrawable; SwiftTerm records the missed frame, but that state is only consumed after a successful command buffer completes.
The compatibility bridge uses public SwiftTerm 1.14 APIs: selectionChanged(source:) marks the visible Metal range dirty, while a same-size setFrameSize(_:) immediately reaches SwiftTerm internal Metal display request without changing the PTY geometry.
Testing
Fixes #1128