chore(skills): add cmux skills - #1305
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e4418eb9d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if any(full.startswith(s + ".") for s in supported): | ||
| continue |
There was a problem hiding this comment.
Reject unknown shortcut action IDs during validation
When a shortcut action ID is misspelled, such as shortcuts.bindings.newTba, this prefix check accepts it because shortcuts.bindings is itself in the supported-path list. Consequently, cmux-settings validate exits successfully even though references/shortcut-actions.md defines a closed set of action IDs, leaving a nonfunctional binding undetected; validate dynamic object children according to their schema rather than accepting every descendant.
Useful? React with 👍 / 👎.
| | [references/trigger-flash-and-health.md](references/trigger-flash-and-health.md) | Flash cue and surface health checks | | ||
| | [../cmux-workspace/SKILL.md](../cmux-workspace/SKILL.md) | Current caller workspace rules and non-disruptive automation | | ||
| | [../cmux-settings/SKILL.md](../cmux-settings/SKILL.md) | Safe cmux.json settings edits and validation | | ||
| | [../cmux-browser/SKILL.md](../cmux-browser/SKILL.md) | Browser automation on surface-backed webviews | |
There was a problem hiding this comment.
Remove or install the referenced cmux-browser skill
When an agent follows this browser-automation reference, the target does not exist: a repo-wide search found only this link and the matching link in cmux-workspace, with no .agents/skills/cmux-browser, Claude symlink, or lock entry. Include the referenced skill in this package or remove the dead deep-dive link so browser requests do not lead agents to a missing instruction file.
Useful? React with 👍 / 👎.
Why
The local
maincheckout contained one unpublished change: four cmux operator skills installed frommanaflow-ai/cmux. The other local-only commits were merge history or the already-landed semantic-read PR #1255. This PR preserves and publishes only the genuinely unlanded cmux package on top of currentorigin/main.What Changed
.agents/skills/.skills-lock.json.Implementation Details
The original local commit was replayed without product-code changes onto current
main(a9f4e085) and recommitted with the required semantic title and DCO sign-off. The prior local main tip is retained locally asbackup/main-pre-sync-20260823.Testing
Automated
just package-check: passed.git diff --cached --check: passed before commit.Manual
.claude/skills/*entries are symlinks to the corresponding.agents/skills/*packages.Risks / Follow-ups