Run CI tests on PHP 8.4 instead of 8.2 - #23
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
basi
marked this pull request as ready for review
August 26, 2026 08:21
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the CI test matrix to run on PHP 8.4 instead of PHP 8.2.
The codebase already ships PHP 8.4 fixes (changelog 2025-02-04, upstream kamilwylegala#83 merged as f9dc42f) and downstream consumers run this fork on PHP 8.4 in production, but CI has never actually exercised 8.4 — the highest version in the matrix was 8.2.
Changes
.github/workflows/tests.yml: matrix include8.2 × mysql→8.4 × mysql. Resulting matrix:8.0 × (mysql, pgsql, sqlite)+8.4 × mysql.README.md: updated the stale "Github actions are running tests on PHP 8.0, 8.1." note to reflect the new matrix (it was already out of date vs. the actual 8.0/8.2 matrix).Verification
setup-phpextensions step (mcryptincluded) installs cleanly on 8.4.convertDeprecationsToExceptionsdefaults tofalse, so new PHP 8.4 deprecation notices do not fail the suite.Install PHP with extensionsstep runs before Composer and validates the PHP 8.4 toolchain immediately; full test verification is blocked by the pre-existing Composer failure below.Known CI status
Install Composer Packagesdue to the Composer >= 2.9 security-advisory policy (broken onmainsince Nov 2025, unrelated to this change — the fix lives in Bump PHPUnit to ^9.6.33 to fix CVE-2026-24765 (Dependabot alert #3) #21). Once Bump PHPUnit to ^9.6.33 to fix CVE-2026-24765 (Dependabot alert #3) #21 merges, re-running this PR's workflow will execute the full suite; no rebase is needed because PR CI runs on the merge ref.custom_taginbump-version.ymlis intentionally untouched: 1.2.0 is reserved by Backport view path containment check for CVE-2026-48820 #22 and a CI-only change needs no release. The resulting duplicate-tag failure of the Bump version workflow on merge is known and harmless (same as the build(deps): bump actions/checkout from 4 to 5 #18 merge).🤖 Generated with Claude Code