Skip to content

Ensure compatibility with Wagtail 3.0#18

Open
Siburg wants to merge 1 commit into
bashu:developfrom
Siburg:wagtail_3_plus_compatibility
Open

Ensure compatibility with Wagtail 3.0#18
Siburg wants to merge 1 commit into
bashu:developfrom
Siburg:wagtail_3_plus_compatibility

Conversation

@Siburg
Copy link
Copy Markdown

@Siburg Siburg commented Jun 4, 2023

Work In Progress PR to implement #17. Not yet intended for merging.

Work done:

  • Apply Wagtail 3.0 changes to module paths
  • Replace ImageChooserPanel with FieldPanel
  • Remove obsolete Wagtail SiteMiddleware references
  • Remove default_app_config for Django 3.2
  • Update requirements.txt and setting for example app
  • Update external links in base.html
  • Start updating README.rst and setup.cfg
  • Fix linter complaints

To do:

  • review testing and desired package compatability
  • update tox.ini
  • continue updating README.rst and setup.cfg
    Maybe other things as well that I have not thought of yet.

- Apply Wagtail 3.0 changes to module paths
- Replace ImageChooserPanel with FieldPanel
- Remove obsolete Wagtail SiteMiddleware references
- Remove default_app_config for Django 3.2
- Update requirements.txt and setting for example app
- Update external links in base.html
- Start updating README.rst and setup.cfg
- Fix linter complaints
@Siburg
Copy link
Copy Markdown
Author

Siburg commented Jun 4, 2023

@bashu here is initial, incomplete PR. Running tests locally with pytest is not working for me. Would welcome your views on how to proceed, or I would be happy for you to take it from here; if you wish.

Comment thread example/requirements.txt
Django == 3.2.*
wagtail == 4.1.*
django-meta >= 2.1.0 # https://github.com/nephila/django-meta
puput == 1.2.0 # https://github.com/APSL/puput
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could consider going to version 1.2.1. That adds support for Django 4 versions, but drops support for Python 3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant