Skip to content

Cache playwright install step on code changes #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewispb merged 1 commit into from
Apr 17, 2026
Merged

Cache playwright install step on code changes #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions lib/generators/upright/install/templates/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ COPY Gemfile Gemfile.lock ./
RUN --mount=type=secret,id=GITHUB_TOKEN \
BUNDLE_GITHUB__COM="$(cat /run/secrets/GITHUB_TOKEN):x-oauth-basic" bundle install && \
rm -rf ~/.bundle/ "${BUNDLE_PATH}"/ruby/*/cache "${BUNDLE_PATH}"/ruby/*/bundler/gems/*/.git && \
bundle exec bootsnap precompile --gemfile
bundle exec bootsnap precompile --gemfile && \
bundle exec ruby -e "require 'upright/version'; puts Upright::PLAYWRIGHT_VERSION" > /tmp/playwright_version

# Copy application code
COPY . .
Expand All @@ -50,18 +51,20 @@ RUN SECRET_KEY_BASE_DUMMY=1 ./bin/rails assets:precompile
# Final stage for app image
FROM base

# Copy built artifacts: gems, application
COPY --from=build "${BUNDLE_PATH}" "${BUNDLE_PATH}"
COPY --from=build /rails /rails

# Install Playwright at the version pinned by the upright gem into a shared path
# so the non-root rails user can access the browser binaries at runtime
# Install Playwright before copying app code so the layer is cached on code-only deploys.
# The version is extracted to a file in the build stage; BuildKit's content-based caching
# keeps this layer cached even across Gemfile changes when the version is unchanged.
COPY --from=build /tmp/playwright_version /tmp/playwright_version
ENV PLAYWRIGHT_BROWSERS_PATH=/ms-playwright
RUN PLAYWRIGHT_VERSION=$(bundle exec ruby -e "require 'upright/version'; puts Upright::PLAYWRIGHT_VERSION") && \
RUN PLAYWRIGHT_VERSION=$(cat /tmp/playwright_version) && \
npm install -g playwright@~${PLAYWRIGHT_VERSION}.0 && \
playwright install --with-deps chromium && \
chmod -R o+rx /ms-playwright

# Copy built artifacts: gems, application
COPY --from=build "${BUNDLE_PATH}" "${BUNDLE_PATH}"
COPY --from=build /rails /rails

# Run and own only the runtime files as a non-root user for security
RUN groupadd --system --gid 1000 rails && \
useradd rails --uid 1000 --gid 1000 --create-home --shell /bin/bash && \
Expand Down
Loading