Skip to content

refactor(L1): drop MIN_NOTICE check from registerUpgrade#376

Merged
PelleKrab merged 1 commit into
mainfrom
remove-register-upgrade-notice
Jul 15, 2026
Merged

refactor(L1): drop MIN_NOTICE check from registerUpgrade#376
PelleKrab merged 1 commit into
mainfrom
remove-register-upgrade-notice

Conversation

@PelleKrab

Copy link
Copy Markdown
Contributor

Description

Removes the MIN_NOTICE requirement from ProtocolVersions.registerUpgrade. The owner can now register an upgrade with any activation timestamp, including one inside the notice window or in the past, in a single call.

The notice period still applies where it matters: changing a timestamp after the fact. setTimestamp and the incident responder's delayTimestamp are unchanged and keep enforcing MIN_NOTICE.

Rationale

The notice window exists to guarantee offchain nodes lead time when an existing schedule entry moves. At registration time there is no existing entry anyone could have relied on, the owner is trusted to pick the activation, and requiring block.timestamp + 1 hours only adds friction (e.g. seeding a schedule with already-activated historical forks).

Changes

  • src/L1/ProtocolVersions.sol: remove the ProtocolVersions_InsufficientNotice check from registerUpgrade; update NatSpec on registerUpgrade and MIN_NOTICE.
  • test/L1/ProtocolVersions.t.sol: replace test_registerUpgrade_insufficientNotice_reverts with test_registerUpgrade_shortNotice_succeeds; setTimestamp notice/past-timestamp revert tests unchanged.
  • snapshots/semver-lock.json: regenerated.

No semver bump: ProtocolVersions (1.0.0) has not launched yet.

@cb-heimdall

cb-heimdall commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@PelleKrab PelleKrab merged commit ee6bac4 into main Jul 15, 2026
6 checks passed
@PelleKrab PelleKrab deleted the remove-register-upgrade-notice branch July 15, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants