refactor(L1): drop MIN_NOTICE check from registerUpgrade#376
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
jackchuma
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
MIN_NOTICErequirement fromProtocolVersions.registerUpgrade. The owner can now register an upgrade with any activation timestamp, including one inside the notice window or in the past, in a single call.The notice period still applies where it matters: changing a timestamp after the fact.
setTimestampand the incident responder'sdelayTimestampare unchanged and keep enforcingMIN_NOTICE.Rationale
The notice window exists to guarantee offchain nodes lead time when an existing schedule entry moves. At registration time there is no existing entry anyone could have relied on, the owner is trusted to pick the activation, and requiring
block.timestamp + 1 hoursonly adds friction (e.g. seeding a schedule with already-activated historical forks).Changes
src/L1/ProtocolVersions.sol: remove theProtocolVersions_InsufficientNoticecheck fromregisterUpgrade; update NatSpec onregisterUpgradeandMIN_NOTICE.test/L1/ProtocolVersions.t.sol: replacetest_registerUpgrade_insufficientNotice_revertswithtest_registerUpgrade_shortNotice_succeeds;setTimestampnotice/past-timestamp revert tests unchanged.snapshots/semver-lock.json: regenerated.No semver bump:
ProtocolVersions(1.0.0) has not launched yet.