feat(L1): bind aggregate proofs to ProtocolVersions schedule#359
Open
PelleKrab wants to merge 1 commit into
Open
feat(L1): bind aggregate proofs to ProtocolVersions schedule#359PelleKrab wants to merge 1 commit into
PelleKrab wants to merge 1 commit into
Conversation
641b312 to
0964d31
Compare
0570814 to
7cb1c5d
Compare
0964d31 to
9c49406
Compare
7cb1c5d to
e1ebc49
Compare
a3fbbb6 to
90bf7d3
Compare
Collaborator
🟡 Heimdall Review Status
|
Co-authored-by: Codex <codex-noreply@coinbase.com>
90bf7d3 to
faecf86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #353.
Pins each
AggregateVerifiergame to theProtocolVersions.scheduleId()that is active when the gameis initialized, and includes that pinned value in the TEE and ZK proof journals.
PROTOCOL_VERSIONS.scheduleId()once during initialization andstore it as
scheduleIdbound to the upgrade schedule that existed when the game was created
ProtocolVersionsproxy into
AggregateVerifierIAggregateVerifierexposesPROTOCOL_VERSIONSandscheduleId; tests coverthat later schedule changes do not alter an initialized game's pinned value
Test plan
forge test --match-path test/L1/proofs/AggregateVerifier.t.solforge test --match-path test/L1/proofs/DisputeGameFactory.t.solforge test --match-path test/L1/OptimismPortal2.t.solforge test --match-path 'test/L1/proofs/*.t.sol'forge fmt --check