[eric-ships]

BOP-221

Motivation

check-coverage.py flagged two missing test files for ActivationRegistry:

• test/unit/ActivationRegistry/activate_revertOrder.t.sol
• test/unit/ActivationRegistry/deactivate_revertOrder.t.sol

RevertOrder files document and enforce the priority ordering of reverts when multiple error conditions hold simultaneously. For activate, the only multi-revert scenario is an unauthorized caller attempting to activate an already-activated feature; access control must fire before the state check. The deactivate file is a forward stub matching the same pattern for when a deactivate function is added.

What changed

• Added activate_revertOrder.t.sol with test_activate_revertOrder_unauthorized_beats_alreadyActivated stub documenting that Unauthorized fires before AlreadyActivated.
• Added deactivate_revertOrder.t.sol with test_deactivate_revertOrder_unauthorized_beats_featureNotActivated stub matching the same access-control-first ordering convention.
• Both files inherit from ActivationRegistryTest, follow the // unimplemented stub convention used across this test suite, and pass forge fmt.

type=routine
risk=low
impact=sev5

[linear]

BOP-221 feat(base-std): automated interface coverage check in CI

Context

base-std tests are the behavioral spec for the base/base Rust precompile implementations. If a function exists in an interface but has no test file, the Rust implementation can diverge silently. There is currently no automated enforcement that every interface function has corresponding test coverage.

What to build

A script (scripts/check-coverage.sh or similar) that:

1. Parses src/interfaces/IB20*.sol for all external function signatures
2. For each function on each contract, checks for test files by category:
   • test/unit/<Contract>/<function>.t.sol (happy path, mandatory for all non-view functions)
   • test/unit/<Contract>/<function>_revertOrder.t.sol (mandatory for functions with revert conditions)
   • test/unit/<Contract>/<function>_rollback.t.sol (mandatory for functions that mutate multiple storage slots)
3. Outputs a gap report and exits non-zero if required files are missing
4. Runs in CI on every PR as a step before forge test

Success criteria

• Adding a new external function to an interface without a corresponding test file fails CI
• The script is fast (pure shell/Python, no compilation)
• Gap report is human-readable and actionable

Review in Linear

[ilikesymmetry]

this PR is small enough to do test implementation in one go vs leaving as unimplemented

[eric-ships]

this PR is small enough to do test implementation in one go vs leaving as unimplemented

@ilikesymmetry Fixed 59968a6

[github-actions]

⚠️ Fork tests: 2 failed, 604 passed

These failures indicate divergences where base/base needs to catch up to the base-std spec. This check is advisory and does not block merging.

Failing tests

• test_createB20_revert_emptyCurrency(address,bytes32): Error != expected error: MissingRequiredField("currency") != InvalidCurrency(""); counterexample: calldata=0xa8dd497d0000000000000000000000000000000000000000000000000000000000006df20000000000000000000000000000000000000000000000000000000000005739 args=[0x0000000000000000000000000000000000006Df2, 0x0000000000000000000000000000000000000000000000000000000000005739]