Repository navigation
fix(base-std): remove isin as required field for security token creation - #104
Merged
Merged
Conversation
The Rust precompile does not enforce isin as required — the fork test test_createB20_revert_missingIsin was failing with a custom error mismatch, confirming the divergence. Remove the empty-string guard from MockB20Factory and delete the corresponding test so the mock matches the precompile behavior. isin remains an optional string on B20SecurityCreateParams; creation with an empty isin succeeds and simply does not seed the ISIN identifier. BOP-220
BOP-220 fix(base-std): remove isin as a required field for security token creation
Context
What to change
The |
eric-ships
marked this pull request as ready for review
June 1, 2026 19:35
ilikesymmetry
approved these changes
Jun 1, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BOP-220
Motivation
isinis an optional identifier. Security tokens that don't have an ISIN assigned at creation should be creatable; the identifier can be set later viaupdateSecurityIdentifier.