Skip to content

⚡ Bolt: [performance improvement] optimize getMovieCreators label lookups #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bartholomej wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡ Bolt: [performance improvement] optimize getMovieCreators label lookups #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 42 additions & 27 deletions src/helpers/movie.helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,38 @@ const parseMoviePeople = (el: HTMLElement): CSFDMovieCreator[] => {
// }
// };

const CREATOR_KEYS = [
'directors',
'writers',
'cinematography',
'music',
'actors',
'basedOn',
'producers',
'filmEditing',
'costumeDesign',
'productionDesign',
'sound'
] as const;

type CreatorKey = typeof CREATOR_KEYS[number];

// Precompute language maps to avoid O(N*M) lookups inside getMovieCreators
const LOCALIZED_CREATOR_LABELS: Record<string, Record<string, CreatorKey>> = {
cs: {},
en: {},
sk: {}
};

for (const lang of ['cs', 'en', 'sk']) {
for (const key of CREATOR_KEYS) {
const label = getLocalizedCreatorLabel(lang, key) as string;
// Remove colons and trim for reliable O(1) matching against HTML text
const normalizedLabel = label.replace(/:/g, '').trim();
LOCALIZED_CREATOR_LABELS[lang][normalizedLabel] = key;
}
}

export const getMovieCreators = (el: HTMLElement, options?: CSFDOptions): CSFDCreators => {
const creators: CSFDCreators = {
directors: [],
Expand All @@ -318,35 +350,18 @@ export const getMovieCreators = (el: HTMLElement, options?: CSFDOptions): CSFDCr
};

const groups = el.querySelectorAll('.creators h4');

const keys = [
'directors',
'writers',
'cinematography',
'music',
'actors',
'basedOn',
'producers',
'filmEditing',
'costumeDesign',
'productionDesign',
'sound'
] as const;

const localizedLabels = keys.map((key) => ({
key,
label: getLocalizedCreatorLabel(options?.language, key) as string
}));
const lang = options?.language || 'cs';
const labelMap = LOCALIZED_CREATOR_LABELS[lang] || LOCALIZED_CREATOR_LABELS['cs'];

for (const group of groups) {
const text = group.textContent.trim();
for (const { key, label } of localizedLabels) {
if (text.includes(label)) {
if (group.parentNode) {
creators[key] = parseMoviePeople(group.parentNode as HTMLElement);
}
break;
}
// ⚡ Bolt Performance Optimization:
// O(1) property lookup replaces previous nested loops.
// Removes the trailing colon from HTML text (e.g., 'Režie:' -> 'Režie') for exact matching.
const text = group.textContent.replace(/:/g, '').trim();
const key = labelMap[text];

if (key && group.parentNode) {
creators[key] = parseMoviePeople(group.parentNode as HTMLElement);
}
}

Expand Down
Loading