Skip to content

⚡ Bolt: [performance improvement] Extract regex from loops in movie.helper.ts #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bartholomej wants to merge 3 commits into
base: master
Choose a base branch
from
Open

⚡ Bolt: [performance improvement] Extract regex from loops in movie.helper.ts #144

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e731b62
perf(movie-helper): extract CLEAN_TEXT_REGEX to constant
google-labs-jules[bot] Mar 25, 2026
6ef34ae
perf(movie-helper): extract CLEAN_TEXT_REGEX to constant
google-labs-jules[bot] Mar 25, 2026
4fb965c
perf(movie-helper): extract CLEAN_TEXT_REGEX to constant
google-labs-jules[bot] Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/helpers/movie.helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ import {
parseLastIdFromUrl
} from './global.helper';

// Optimization: Extract regex from mapping loops to avoid recompilation overhead
const CLEAN_TEXT_REGEX = /(\r\n|\n|\r|\t)/gm;

const CREATOR_LABELS: Record<
string,
Record<string, CSFDCreatorGroups | CSFDCreatorGroupsEnglish | CSFDCreatorGroupsSlovak>
Expand Down Expand Up @@ -264,7 +267,7 @@ export const getMovieRandomPhoto = (el: HTMLElement | null): string => {
export const getMovieTrivia = (el: HTMLElement | null): string[] => {
const triviaNodes = el.querySelectorAll('.article-trivia ul li');
if (triviaNodes?.length) {
return triviaNodes.map((node) => node.textContent.trim().replace(/(\r\n|\n|\r|\t)/gm, ''));
return triviaNodes.map((node) => node.textContent.trim().replace(CLEAN_TEXT_REGEX, ''));
} else {
return null;
}
Expand All @@ -273,7 +276,7 @@ export const getMovieTrivia = (el: HTMLElement | null): string[] => {
export const getMovieDescriptions = (el: HTMLElement): string[] => {
return el
.querySelectorAll('.body--plots .plot-full p, .body--plots .plots .plots-item p')
.map((movie) => movie.textContent?.trim().replace(/(\r\n|\n|\r|\t)/gm, ''));
.map((movie) => movie.textContent?.trim().replace(CLEAN_TEXT_REGEX, ''));
};

const parseMoviePeople = (el: HTMLElement): CSFDMovieCreator[] => {
Expand Down
Loading