feat: manage IngressClass, ClusterRole, ClusterRoleBinding - #9
Merged
Conversation
Adds the three cluster-scoped resources that were still missing from the manageable set (Ingress, ServiceAccount, Role, RoleBinding and NetworkPolicy were already supported): - kube-core: store projections (ingress_classes_table, cluster_roles_table, cluster_role_bindings_table) and list/get/delete arms in LocalKube — cluster-scoped, like StorageClass/CRD. - frontend: Ingress Classes added to the Network view; Cluster Roles and Cluster Role Bindings to the Access Control view; all three added to DELETABLE_KINDS and kindLabel. Works in both Direct and Remote modes (the kind string flows through the generic list/get/delete path). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds management for the additional Kubernetes objects requested.
Five of the eight listed were already manageable (Ingress, ServiceAccount, Role, RoleBinding, NetworkPolicy). This PR adds the three that were missing — all cluster-scoped:
How
Follows the data-driven view convention (AGENTS.md): new
store::*_tableprojections + list/get/delete match arms inkube-core::LocalKube(cluster-scoped, mirroring StorageClass/CRD), plusTABLE_VIEWSsections,DELETABLE_KINDS, andkindLabelentries on the frontend. Thekindstring flows through the generic list/get/delete IPC + backend routes, so it works in both Direct and Remote modes with no new commands.Test
npm run build✓cargo fmt --all -- --check✓cargo clippy --workspace --all-targets -- -D warnings✓cargo test -p kubefront-core✓ (6 passed)🤖 Generated with Claude Code