Updated tests to reflect the use of RequestManagerRestSharp over RequestManager.#11
Open
cofl wants to merge 3 commits intobarrycarey:Developfrom
Open
Updated tests to reflect the use of RequestManagerRestSharp over RequestManager.#11cofl wants to merge 3 commits intobarrycarey:Developfrom
cofl wants to merge 3 commits intobarrycarey:Developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of RequestManagerRestSharp in SnipeItApi was causing the tests CheckApiTokenAndUrl_SetAuthorizationHeader_SetCorrectly and CheckApiTokenAndUrl_SetHttpClientBaseAddress_SetCorrectly to fail with NullReferenceExceptions.
I updated the tests to reflect the use of the new class, and added internals visibility on the main assembly to the test assembly, to limit how much reflection we need to do.