Skip to content

Add searchable emoji picker package#97

Merged
barronlroth merged 7 commits into
mainfrom
codex/mcemojipicker-search
Jun 1, 2026
Merged

Add searchable emoji picker package#97
barronlroth merged 7 commits into
mainfrom
codex/mcemojipicker-search

Conversation

@barronlroth

@barronlroth barronlroth commented May 30, 2026

Copy link
Copy Markdown
Owner

Summary

Notes

  • Upstream PR Added search functionality izyumkin/MCEmojiPicker#57 is still open, not merged into izyumkin/main
  • The owned fork commit squashes the safer CLDR-based keyword implementation rather than using the newer Apple CoreEmoji-derived keyword data from the external fork
  • The bundled CLDR keyword resource is about 79 KB

Validation

  • xcodebuild -resolvePackageDependencies -project Cubby.xcodeproj -scheme Cubby -scmProvider system
  • XcodeBuildMCP simulator build/run with UI-TESTING SEED_MOCK_DATA
  • Visual check: Edit Item picker shows the search bar and normally proportioned category icons
  • Search check: lettuce returns 🥬 in the picker

Related

@barronlroth

Copy link
Copy Markdown
Owner Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 846299d843

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -1,78 +0,0 @@
name: Claude Code Review

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the removed GitHub Actions automation

Deleting this workflow, together with the companion claude.yml, leaves .github/workflows empty in this commit, so opening or updating a PR no longer triggers the automated review job that previously ran on pull_request. For a change whose stated scope is pinning MCEmojiPicker, this unintentionally removes the repository’s only Actions-based PR automation and will affect every subsequent review unless the workflow is restored or replaced.

Useful? React with 👍 / 👎.

@barronlroth barronlroth merged commit fa52966 into main Jun 1, 2026
2 checks passed
@barronlroth barronlroth deleted the codex/mcemojipicker-search branch June 1, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix squished emoji picker category icons

1 participant