Skip to content

fix: preserve masked variable metadata in __array_finalize__ #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
narutamaaurum wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve masked variable metadata in __array_finalize__ #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/PseudoNetCDF/core/_variables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ def array(self):

def __array_finalize__(self, obj):
np.ma.MaskedArray.__array_finalize__(self, obj)
PseudoNetCDFVariable.__array_finalize__(self, obj)

def _update_from(self, obj):
dt = self.dtype.char
Expand Down
19 changes: 19 additions & 0 deletions src/PseudoNetCDF/test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import numpy as np
from PseudoNetCDF import PseudoNetCDFFile, PseudoNetCDFVariables
from PseudoNetCDF import PseudoNetCDFVariable, pncopen
from PseudoNetCDF.core._variables import PseudoNetCDFMaskedVariable
from . import requires_basemap, requires_pyproj, requires_matplotlib
from . import compare_files
from PseudoNetCDF.pncwarn import warn
Expand Down Expand Up @@ -49,6 +50,24 @@ def testFromArray(self):
assert (var.dimensions == ('y', 'x'))
np_all_close(var[:], self.myarray)

def testMaskedArrayFinalizeCopiesPseudoNetCDFMetadata(self):
parent = PseudoNetCDFFile()
parent.createDimension('y', 1)
parent.createDimension('x', 5)
masked = np.ma.array(self.myarray[:1], mask=[[0, 1, 0, 1, 0]])
var = PseudoNetCDFMaskedVariable(
parent, 'unknown', 'f', ('y', 'x'),
values=masked, units='unknown', long_name='masked variable'
)

copied = var.copy()

assert (copied.dimensions == ('y', 'x'))
assert (copied.getncatts() == {
'units': 'unknown', 'long_name': 'masked variable',
})
np.testing.assert_array_equal(copied.mask, masked.mask)


class PseudoNetCDFFileTest(unittest.TestCase):
def setUp(self):
Expand Down