Enhancement/camx-py312 - #155
Merged
Merged
Conversation
After v7.4.3, coverage causes netCDF4 to report a runtime error RuntimeError: NetCDF: Not a valid ID It is not clear to me why this happens, but it is reliable. v7.4.4 and above cause the error, which can be bypassed by downgrading coverage or by using pytest directly. The test does not strictly depend on increasing coverage, so I am removing it.
flake8 does not like explicit global statements if the variable is never defined within a function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to support py312, newer flake8 requirements, and skip the testOpenMFDataset. The skipped test is due to race conditions on parallel platforms, which are seemingly only present under specific conditions.
passes tox for py39, py311, and py312