Repository navigation
feat(analyze): Mole parity B2 — batch delete, overview/insights, scan cache (P9–P11) - #4
Merged
Merged
Conversation
…actions (Phase 10) - Add overview view mode in AnalyzeTui with 4 locations (Home, Downloads, User Cache, Root) - Add hidden-space insights rows (old downloads >90 days pointer to mu installer, cleanable artifacts) - Add [cleanable] badges for node_modules, target, .venv, dist, CACHEDIR.TAG excluding mu clean roots - Derive clean target roots from built-in clean targets list (src/clean/targets.rs) - Implement actions: R (rescan), O (open dir via xdg-open), F (reveal file via xdg-open), P (text preview modal) - Enforce GUI safety: refuse xdg-open when DISPLAY/WAYLAND_DISPLAY are absent with informative message - Route external commands through Runner (ProcessRunner / FakeRunner) - Fix folded-in Phase 9 navigate_up filter restore issue with regression test - Retain exact byte-level non-TTY and --json contracts and empty golden diff
… 11) - Add `src/analyze/cache.rs` keyed by schema version and canonical root path - Use atomic write via temporary file and rename on same filesystem - Ignore relative `XDG_CACHE_HOME` falling back to standard cache dir via `crate::xdg::cache_home()` - Treat read errors, corrupt files, and schema mismatches as cache misses - Derive `Deserialize` on `FileNode` and `ScanStats` with serde defaults for non-serialized fields - Support cache bypass in walker and ensure `--json` always scans fresh - Invalidate affected root cache on single delete, batch delete, and 'R' rescan in AnalyzeTui - Add unit tests for roundtrip, corrupt file, schema mismatch, invalidation, relative XDG_CACHE_HOME, and fresh JSON scan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
B2 of the Mole parity plan (docs/plans/active/mole-parity.md), P9 → P11.
0bdf9ff: multi-select, batch delete with re-lstat → whitelist → trash → oplog, name filter72fe21b: Overview start screen, insights, cleanable badges, R/O/P/F actionsa8bf7b8: versioned scan cache under$XDG_CACHE_HOME/mu/analyze; R and delete invalidate it,--jsonis always freshVerification (on a8bf7b8)
make test: 467 unit + 59 integration, 0 failedmake lint(clippy-D warnings): cleantests/goldenunchangedKnown follow-ups (not blocking)
--jsonwrites a cache it never reads. Fix: a size guard, or skip saving on bypass.CleanTargethas no roots field, so the badge roots are enumerated separately. If they drift, only the badges are wrong; nothing gets deleted.from therealTINHTUTE with love ❤️❤️❤️