Skip to content

Setup and add-3d can report success after a failed write #20

Open

Description

@barisgit

Found during #17 review.

  • commands/setup/changes.py (~124-126, ~225-227) and setup/command.py (~224-227): environment-variable and pin write failures can be treated as unchanged state while setup continues and reports success.
  • commands/setup/changes.py (~187-190): library-table additions use only the primary symbol-library directory even when several libraries are selected.
  • commands/add_3d/command.py (~99, ~132, ~258): metadata write results are ignored.
  • utils/metadata writers truncate the file before writing; use write_atomically so a failed write cannot leave it empty.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions