Draft
Conversation
This will be handled by the filtering strategies themselves in the future
Since we will be adding other stategy-specific files/modules soon
These can manage all of the filtering-specific logic bound to the set and the AttributeInstruction
Must manually turn on coverage and failure reports
Test both ActiveRecord and Enumerable sets Fix the scope spec when dealing with computed scopes Make the predicate specs work off of the filtering predicate constants
…instructions with the filtering operation
Must manually turn on coverage and failure reports
… (like 19XX-04-31)
…-intersection-filtering Fix enumerable intersection filtering when working across associations
…etup Change the default spec running behavior
Fix rubocop issues
# Conflicts: # lib/active_set/enumerable_set_instruction.rb # lib/active_set/filtering/enumerable_strategy.rb
…the namespaced class
…ion-set-instructions Feature/operation set instructions
# Conflicts: # lib/active_set/active_record_set_instruction.rb # lib/active_set/enumerable_set_instruction.rb # lib/active_set/filtering/active_record/set_instruction.rb # lib/active_set/filtering/active_record/strategy.rb # lib/active_set/filtering/enumerable/set_instruction.rb # lib/active_set/filtering/enumerable/strategy.rb # spec/active_set/filter/scopes_spec.rb
…nstructions Allow sort params to be passed in short or long form
…tion-helpers Add view helpers for the range of records shown on the current page
bundle exec rubocop --safe-auto-correct .
…p to define type hints for filter attributes
…e-coverage Feature/improve coverage
…ed-type-inferencing Feature/improved type inferencing
…ing the type inferencing when filtering a set
{ foo: :desc, bar: :asc }
or
{
'1': {
attribute: :bar,
operator: :asc,
query: 'foo'
},
'0': {
attribute: :foo,
operator: :desc,
query: 'foo'
}
}
{ :foo=>:desc, :bar=>:asc }
or
{
'1': {
attribute: :bar,
operator: :asc,
query: 'foo'
},
'0': {
attribute: :foo,
operator: :desc,
query: 'foo'
}
}
…into instructions into service classes
…riendly-params Feature/form friendly params
…ether to run all possible paths or only a randomly selected path based on an ENV variable
…s-all-tests Feature/ci runs all tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@barendt I would like to test this on staging, but here is the null sorting code in a separate branch.