chore: silence flax/optax deprecation warnings in trainer + tests#26
Merged
Conversation
Three migrations in one PR, all mechanical: - optax.global_norm -> optax.tree.norm (2 sites in trainer.py). - nnx.State.merge -> nnx.merge_state (trainer.py + test_checkpoint_roundtrip). - nnx.Variable.value -> variable[...] (for Variable[Array] — iterations, training_steps) or variable.get_value()/set_value() (for non-Array Variable types — the _metrics_accumulator that wraps a PyTreeNode). ~9 call sites across trainer.py, ppo_trainer.py, alphazero_trainer.py. Warning count drops from 100 to 9. The remaining 9 are upstream (distrax's jax.core.get_aval and pgx's player_id-in-observe), not ours to fix in this PR. No behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundled cleanup of the deprecation warnings CI was flagging on every run. Three migrations, all mechanical, no behavior change.
The `.value` migration distinguishes two cases per flax's deprecation notice:
Warning count
Test plan
🤖 Generated with Claude Code