Repository navigation
Add the generated baseline profile - #41
Merged
Merged
Conversation
The profile test opened the app chooser instead of Wick, because its launch intent named no app. It now names MainActivity, and the generated startup and baseline profiles are committed so release builds compile the startup and scroll paths at install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release builds now ship a baseline profile, so Android compiles the startup and list scroll code at install time instead of after several days of use.
Changes
startWithFakeData()launched an intent with no component, so Android showed the app chooser and the profile test always failed. The intent now namesMainActivity.app/src/release/generated/baselineProfiles/holds the generatedbaseline-prof.txtandstartup-prof.txt(about 23k rules, 1,877 of them in Wick's own code).How it was generated
./gradlew :app:generateBaselineProfile -Pandroid.testInstrumentationRunnerArguments.androidx.benchmark.enabledRules=BaselineProfileon an Android 14 emulator (Google APIs, x86_64). The run covers cold start with 500 fake items, scrolling and flinging the list, the drawer, and the text sheet.Check
assembleReleasenow putsassets/dexopt/baseline.prof(11 KB) in the APK.Regenerate with the same command when the startup or scroll path changes a lot.