Repository navigation
Article text, icons and picker fixes - #40
Merged
Merged
Conversation
bardesss
force-pushed
the
fix/review-phase-4
branch
from
November 13, 2026 04:11
ee06a4f to
553bf5b
Compare
bardesss
force-pushed
the
fix/review-phase-5
branch
from
November 13, 2026 04:11
5dbd0ae to
44b9bc3
Compare
bardesss
force-pushed
the
fix/review-phase-5
branch
from
November 13, 2026 04:13
44b9bc3 to
f01e948
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Article text, icons and picker fixes. Stacked on #39; merge that first.
Article text
Images and icons
HttpUrl, which encodes spaces and similar characters and only accepts http and https.Picker
Tests:
HtmlTextTest,LeadImageTest, newSvgIconsTest,FaviconTest,PickerDrawerFoldTest. Full unit tests and lint pass.Fixes from the final review