Repository navigation
Sign in, sign out and stored credentials fixes - #38
Merged
Merged
Conversation
Servers order the unread listing by when they fetched an item, not by its publish date, so a publish-time window could mark items read that are still unread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sign-in, sign-out and stored credentials. Stacked on #37.
ClientLoginmaps toBadCredentials, so a wrong key shows "Username or API key is wrong" instead of "The server refused access".KeystoreCredentialStore.loadtries decryption 3 times. Only a permanent failure (AEADBadTagException,KeyPermanentlyInvalidatedException,UnrecoverableKeyException, bad base64, or plaintext without a newline) deletes the stored sign-in. Any other error keeps it for the next start, and a failing removal can no longer crash startup.HttpUrlcannot parse, or that is not https, shows "That address doesn't look right" before any request. The Sign in button is disabled while a field is blank.AccountSwitchcompares account ids without case, so signing in again asAliceinstead ofalicekeeps the local data and queued marks.MarkAllArmand 4 s timeout as mark all read.HeaderIconand the timeout constant are now shared.Tests:
GReaderApiTest,CredentialStoreTest,LoginViewModelTest, newLoginScreenTest,SignOutTestandSettingsScreenTest. Full unit tests and lint pass.