Repository navigation
fix(chat): a table's text selects as the text around it does - #723
Merged
Merged
Conversation
A drag beside a row of a table that scrolls sideways selected every row below it: Flutter's scroll view took an edge past its side as past all of it, and kept from one drag to the next whether the drag had begun in it. The table now has its own selection: an edge beside a row is at that row's end (at the edge of what shows, scrolling on, when the drag began in the table). Copied, a row is a line, its cells apart by tabs. Co-Authored-By: BaoCode <noreply@baocode.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a reply's table that scrolls sideways, selecting went wrong:
The table now has its own selection, the scroll view's off:
Tests:
test/markdown_test.dart(newtables / selectedcases).selection_scroll_test.dart's trackpad fling case fails on main as well.🤖 Generated with BaoCode