Skip to content

fix(chat): a table's text selects as the text around it does - #723

Merged
leookun merged 1 commit into
mainfrom
table-selection
Nov 4, 2026
Merged

leookun merged 1 commit into
mainfrom
table-selection

Conversation

@leookun

@leookun leookun commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

In a reply's table that scrolls sideways, selecting went wrong:

  • A drag from above the table to beside a row selected the whole table; one from below to beside a row selected none of it.
  • After one drag across the table, a drag in a row out past the table's edge selected every row below it (Flutter's scroll view keeps, from one drag to the next, whether the drag began in it, and takes an edge past its side as past all of it).
  • Copied, the cells ran together with nothing between them.

The table now has its own selection, the scroll view's off:

  • An edge beside a row is at that row's end (or start): at the edge of what shows when the drag began in the table, which scrolls on toward it (stepped a frame at a time, not Flutter's auto-scroller, which spun without end in tests), else past all of the row.
  • Copied, a row is a line and its cells are apart by tabs, as a spreadsheet takes them.

Tests: test/markdown_test.dart (new tables / selected cases). selection_scroll_test.dart's trackpad fling case fails on main as well.

🤖 Generated with BaoCode

A drag beside a row of a table that scrolls sideways selected every row
below it: Flutter's scroll view took an edge past its side as past all of
it, and kept from one drag to the next whether the drag had begun in it.
The table now has its own selection: an edge beside a row is at that
row's end (at the edge of what shows, scrolling on, when the drag began
in the table). Copied, a row is a line, its cells apart by tabs.

Co-Authored-By: BaoCode <noreply@baocode.dev>
@leookun
leookun merged commit 8acadb9 into main Nov 4, 2026
@leookun
leookun deleted the table-selection branch November 4, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants