Add Camera.forward() world-space viewing direction#62
Closed
AshSgDe29071999 wants to merge 2 commits into
Closed
Conversation
Expose the OpenCV +z forward axis from R for logging, frustum checks, and look-at round-trip tests. Fixes bamdadd#58
AshSgDe29071999
force-pushed
the
feat/camera-forward
branch
from
July 22, 2026 11:51
7931be2 to
8346169
Compare
Owner
|
Thanks @AshSgDe29071999, and welcome! You and another contributor landed on the same issue (#58) at the same time — #61 came in just ahead and is type-clean under our mypy-strict gate, so I've merged that one. Your implementation was correct on the math; the only gap was mypy ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Camera.forward()returning the world-space unit viewing direction (OpenCV +z / third row ofR).normalize(target - eye).Fixes #58
Test plan