External bridge improvements ported from Prusa Slicer#9659
Open
lin-xianming wants to merge 2 commits intobambulab:masterfrom
Open
External bridge improvements ported from Prusa Slicer#9659lin-xianming wants to merge 2 commits intobambulab:masterfrom
lin-xianming wants to merge 2 commits intobambulab:masterfrom
Conversation
zhimin-zeng-bambulab
requested review from
XunZhangBambu
and removed request for
Diatom-Banbu
lanewei120
requested review from
ArthurBambulab and
dragon-eyes-bbl
and removed request for
XunZhangBambu and
zhimin-zeng-bambulab
Before, partial bridges were calculated. For each of these an angle has been choosen and after that all the bridges have been merged. Becouse of the merge a single angle had to be picked. The first angle that the algorithm has stumbled upon has been picked, resulting in sub-optimal bridging directions. Now the partial bridges are calcualted, then merged and then the angle is decided over the whole merged bridge. This approach at least ensures that the orientation is the best possible for the merged bridge.
lin-xianming
force-pushed
the
patch/external-bridge-fixes
branch
from
ba827d0 to
4fc3bd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch merges adjacent external bridge polygons before calculating the angle.
Currently there is a problem where
detect_bridging_directionis called with non-emptyfloating_edgeseven when the bridge area has no floating edges, such as in the picture below. By merging the bridges first then taking the closing of the merged bridge polygons this problem is fixed.