You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously we have been marking such changes as major (eg in 1ea47cf), since otherwise npm i for users in old node versions would stop.
Since this already works with node16 and flowzone already was testing this against node 12-18, I would personally wait until we have any other major change to do and get the in together.
Let's also change the title to be in present tense like the rest of the commits, like: Drop support for node < 16
Since this already works with node16 and flowzone already was testing this against node 12-18, I would personally wait until we have any other major change to do and get the in together.
We do that only for majors @zoobot b/c customers have raised concerns at some point about doing majors too often making the packages look not mature enough or not well though beforehand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Suites: 22 passed, 22 total
Tests: 560 passed, 560 total
Snapshots: 308 passed, 308 total
Time: 19.182 s
Ran all test suites.
Change-type: patch