Skip to content
This repository was archived by the owner on Jan 16, 2025. It is now read-only.

Updated engine to 16, installed node-modules, ran tests#1660

Open
zoobot wants to merge 1 commit into
masterfrom
node-16
Open

Updated engine to 16, installed node-modules, ran tests#1660
zoobot wants to merge 1 commit into
masterfrom
node-16

Conversation

@zoobot

@zoobot zoobot commented Oct 19, 2022

Copy link
Copy Markdown

Test Suites: 22 passed, 22 total
Tests: 560 passed, 560 total
Snapshots: 308 passed, 308 total
Time: 19.182 s
Ran all test suites.

Change-type: patch

@zoobot zoobot requested a review from thgreasi October 19, 2022 19:49
@zoobot zoobot linked an issue Oct 19, 2022 that may be closed by this pull request
@thgreasi

Copy link
Copy Markdown
Contributor

Previously we have been marking such changes as major (eg in 1ea47cf), since otherwise npm i for users in old node versions would stop.
Since this already works with node16 and flowzone already was testing this against node 12-18, I would personally wait until we have any other major change to do and get the in together.
Let's also change the title to be in present tense like the rest of the commits, like: Drop support for node < 16

@zoobot

zoobot commented Oct 19, 2022

Copy link
Copy Markdown
Author

Since this already works with node16 and flowzone already was testing this against node 12-18, I would personally wait until we have any other major change to do and get the in together.

It's ok to mash unrelated PRs together?

Change-type: major
@thgreasi

thgreasi commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

We do that only for majors @zoobot b/c customers have raised concerns at some point about doing majors too often making the packages look not mature enough or not well though beforehand.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to node 16 at least

2 participants