Fixes compile errors from armgcc 15.#928
Merged
Merged
Conversation
balazsracz
commented
Apr 26, 2026
balazsracz
commented
Collaborator
- there were some missing includes.
- the Device infrastructure generates a new warning due to having both static ::open and virtual ::open functions on the same classes in the hierarchy. This warning needs to be disabled at this point.
- there was a legit bug discovered in PCA8685PWM that impacts only big endian processors.
- there were some missing includes. - the Device infrastructure generates a new warning due to having both static ::open and virtual ::open functions on the same classes in the hierarchy. This warning needs to be disabled at this point. - there was a legit bug discovered in PCA8685PWM that impacts only big endian processors.
bakerstu
approved these changes
Apr 26, 2026
bakerstu
left a comment
bakerstu
left a comment
Owner
There was a problem hiding this comment.
Do we have an issue filed for the -Wno-overloaded-virtual option? If not, let's file one. If yes, let's link it to this pull request, but not close it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.