Repository navigation
BREAKING: Mark All Integers Safe & Tighten Schema - #888
Merged
Merged
Conversation
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
bachmacintosh
enabled auto-merge
October 8, 2026 22:23
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR marks as many known integers as a
SafeIntegertype as possible, going beyond just parameter arguments; this will help make the values more reusable should we make further adjustments to the type, such as branding it.We also used this PR as an opportunity to change any
v.union([type, v.null()])items to simplyv.nullable(type)for brevity; this may be a breaking change for any consumers relying on the issue structure when parsing fails. We also found a couple zod schema that weren't usingz.toZodwhen they should've.Nature of Pull Request
This Pull Request:
Its changes constitutes a:
Contribution Terms
I understand that by submitting this Pull Request: