Skip to content

Chore: Move from corepack to devEngines for Node 26 - #887

Merged
bachmacintosh merged 3 commits into
v3from
node-26
Oct 8, 2026
Merged

bachmacintosh merged 3 commits into
v3from
node-26

Conversation

@bachmacintosh

Copy link
Copy Markdown
Collaborator

Description

The Node.js TSC has voted to stop shipping corepack with Node.js beginning with version 25. Since then, version 26 was released earlier this year, and will become the latest LTS version on October 28. This PR updates our mise.toml and package.json files to version both Node.js and pnpm through the devEngines field on package.json. It also removes the .nvmrc file that's been around since before we used mise-en-place to manage the Node.js version, meaning both the runtime and package manager are versioned in one place. This also allows us to use semantic version specifiers for these tools.

Nature of Pull Request

This Pull Request:

  • Adds/Updates Type(s)/Schemas
  • Adds/Updates Helper Functions/Type Guards
  • Updates Documentation
  • Updates Project and/or Community Health files (e.g. README, GitHub Actions, etc.)

Its changes constitutes a:

  • Non-code change (i.e. no version bump)
  • Bug Fix or Other Small Changes (i.e. patch version bump)
  • Forward-compatible Enhancement (i.e. minor version bump)
  • ⚠️ BREAKING CHANGE regarding TypeScript, Package, and/or WaniKani API version(s) (i.e. MAJOR version bump)

Contribution Terms

I understand that by submitting this Pull Request:

Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

npm view read the root package.json, rejected its pnpm devEngines with
EBADDEVENGINES, and the error JSON was piped onward as the version since
the step lacked pipefail. Point npm at RUNNER_TEMP so it skips the
manifest, and run the step with the explicit bash shell for pipefail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019iS1UYdMG1ykMN9dT1seHj
Signed-off-by: Claude <noreply@anthropic.com>
@bachmacintosh
bachmacintosh added this pull request to the merge queue Oct 8, 2026
Merged via the queue into v3 with commit 2a2cc55 Oct 8, 2026
8 checks passed
@bachmacintosh
bachmacintosh deleted the node-26 branch October 8, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants