Repository navigation
Chore: Move from corepack to devEngines for Node 26 - #887
Merged
Merged
Conversation
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
npm view read the root package.json, rejected its pnpm devEngines with EBADDEVENGINES, and the error JSON was piped onward as the version since the step lacked pipefail. Point npm at RUNNER_TEMP so it skips the manifest, and run the step with the explicit bash shell for pipefail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019iS1UYdMG1ykMN9dT1seHj Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Node.js TSC has voted to stop shipping corepack with Node.js beginning with version 25. Since then, version 26 was released earlier this year, and will become the latest LTS version on October 28. This PR updates our
mise.tomlandpackage.jsonfiles to version both Node.js and pnpm through thedevEnginesfield onpackage.json. It also removes the.nvmrcfile that's been around since before we usedmise-en-placeto manage the Node.js version, meaning both the runtime and package manager are versioned in one place. This also allows us to use semantic version specifiers for these tools.Nature of Pull Request
This Pull Request:
Its changes constitutes a:
Contribution Terms
I understand that by submitting this Pull Request: