Repository navigation
Build before testing in the all script - #45
Merged
Merged
Conversation
The rule tests load oxlint.config.ts, which imports the built dist/ output, so `pnpm all` failed on a fresh clone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TLBzrsN4hMwi77PvoAzqq8
bachmacintosh
marked this pull request as ready for review
October 16, 2026 21:22
bachmacintosh
enabled auto-merge
October 16, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm allnow runspnpm buildbeforepnpm test. This matches the CI order from #44. The rule tests runoxlint --rules, which loads the repo'soxlint.config.ts, and that file imports the builtdist/oxlint/index.mjs. On a fresh clone with nodist/,pnpm allfailed at its first step.Testing
Deleted
dist/, then ranpnpm all: the build, all 2718 tests, typecheck, docs, format and lint passed, and the only change in the working tree was this one.Generated by Claude Code