Repository navigation
fix(release): drop deprecated Homebrew cask stanzas and bump GoReleaser - #95
Merged
Merged
Conversation
Homebrew 7.0 deprecated the `verified:` url parameter, so every `brew` command touching bab-sh/homebrew-tap printed a warning. GoReleaser deprecated the corresponding config key in v2.18.1 and no longer emits it. - Remove `url.verified` from both homebrew_casks entries. - Rename `binary:` to the `binaries:` list form, deprecated since v2.12.6. - Drop the `brews:` section. It was removed in GoReleaser v2.16, so the release would fail on any version past that. `homebrew_casks` already covers macOS and Linux, and prebuilt binaries belong in a cask rather than a formula. - Bump the pinned GoReleaser from v2.14.3 to v2.18.2. The `postflight` deprecation is intentionally left alone: the replacement `hooks.post.install_steps` is milestoned for GoReleaser v2.19.0, which is not released yet. Verified with `goreleaser check` and a snapshot build: the generated cask has no `verified:`, keeps unchanged download URLs and all three shell completions, and no longer emits a Formula. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every
brew update/brew upgradethat touchesbab-sh/homebrew-tapcurrently prints deprecation warnings. Homebrew 7.0 deprecated two cask DSL constructs, and both are on the deprecate → disable → remove path, so these become hard errors in a later Homebrew release.The cask files in the tap are marked
DO NOT EDIT— they are regenerated by GoReleaser on every release, so the fix belongs here.What changed
url.verifiedfrom bothhomebrew_casksentries. GoReleaser deprecated this key in v2.18.1 and no longer writes it to generated casks.binary:→binaries:— the singular form was deprecated in v2.12.6 in favour of a list.brews:section. This is a prerequisite, not a cleanup:brewswas removed in GoReleaser v2.16, so the release would fail outright on the bumped version.homebrew_casksalready covers both macOS and Linux, and per goreleaser#5563 prebuilt binaries belong in a cask — the formula/cask split is build-from-source vs. precompiled, not CLI vs. GUI.Follow-up (not in this PR)
Formula/bab.rbin the tap will stop being updated. It currently shadows the cask —brew info babtoday resolves to the formula — so it needs deleting in a separate tap PR after this lands and a release publishes an updated cask.tap_migrations.jsoncannot automate this: a same-name formula→cask pair is skipped by the guard informulary.rb(if tapped_name != new_tapped_name) and incask/migrator.rb(next false if old_token == new_cask.token). Existing formula users will need:The
postflightdeprecation is deliberately left alone — its replacementhooks.post.install_stepsis milestoned for GoReleaser v2.19.0, which is not released yet (nightlies only). Tracking: goreleaser#6870, PR #6873.Verification
goreleaser checkpasses with no deprecation warnings. A snapshot build (goreleaser release --snapshot --clean --skip=publish,sign,announce) confirms the generated cask:verified:in anyurlstanzabinary "bab"and all three shell completions after the renameFormula/outputpostflight(expected until v2.19)🤖 Generated with Claude Code