chore: remove the CoinPayPortal invoice workflow - #157
Open
sweidinger wants to merge 1 commit into
Open
Conversation
coinpay.yml ran profullstack/coinpaybot@v0 on every issue comment starting with `/coinpay`, holding issues: write and pull-requests: write, against COINPAY_API_KEY and COINPAY_BUSINESS_ID. Neither secret is set on this repository, so the step cannot have succeeded since it landed -- the workflow is not doing a job today that removing it would take away. What it does do is sit on the issue_comment trigger, which anyone with a GitHub account can fire by commenting on any issue or PR. The action behind it is referenced as @v0, a tag its owner can repoint at any commit, so the code that runs on that trigger is not fixed and is not reviewed here. That is a standing write-scoped entry point into the repo in exchange for a feature a torrent search TUI has no use for: there is nothing to invoice. Deleting it rather than pinning it, because pinning would only freeze code that should not be reachable in the first place. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Split out of #156 so the pinning work there can be judged on its own — this one asks a different question, whether the workflow should exist at all, and that is your call rather than a mechanical fix. The two PRs are independent and can merge in either order.
coinpay.ymlrunsprofullstack/coinpaybot@v0on every issue comment starting with/coinpay, holdingissues: writeandpull-requests: write, againstCOINPAY_API_KEYandCOINPAY_BUSINESS_ID. Neither secret is set on this repository, so the step cannot have succeeded since it landed — removing it does not take away something that works today.What it does do is sit on the
issue_commenttrigger, which anyone with a GitHub account can fire by commenting on any issue or PR. The action behind it is referenced as@v0— a tag its owner can repoint at any commit — so the code that runs on that trigger is neither fixed nor reviewed here. That is a standing write-scoped entry point into the repo in exchange for a feature a terminal torrent search client has no use for: there is nothing to invoice.Deleting rather than pinning, because a pin would only freeze code that should not be reachable in the first place.
If this is wrong, it is easy to say so and I will close it. If the secrets are pending and the bot is meant to be live, the right change is the opposite one — set them and pin
coinpaybotto a commit, which I am happy to send instead. I have no visibility into whether this is intentional tooling of yours.Checklist
npm run typecheckis cleannpm testpasses (45 files, 311 tests)HELP_GROUPSandfooterHintsinsrc/ui/keymap.ts— n/aStorefield, I updatedmakeStoreinscripts/render-previews-impl.tsx— n/a