Skip to content

Fix: Add missing mXLed and mYLed instance variables in AdalightClient #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b1ume merged 2 commits into from
Feb 15, 2026
Merged

Fix: Add missing mXLed and mYLed instance variables in AdalightClient #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cfb0b1
Initial plan
Copilot Feb 15, 2026
7fe4096
Add missing mXLed and mYLed instance variables to AdalightClient
Copilot Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions common/src/main/java/com/hyperion/grabber/network/AdalightClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ public enum ProtocolType {
private final int mPriority;
private final int mBaudRate;
private final ProtocolType mProtocol = ProtocolType.ADA; // Default to ADA
private int mXLed;
private int mYLed;
Comment on lines +36 to +37

Copilot AI Feb 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mXLed/mYLed are only assigned once in the constructor and never reassigned; consider making them final to match the rest of the immutable configuration fields in this client (and e.g. WLEDClient).

Suggested change
private int mXLed;
private int mYLed;
private final int mXLed;
private final int mYLed;

Copilot uses AI. Check for mistakes.

private UsbSerialPort mPort;
private volatile boolean mConnected = false;
Expand Down