π‘οΈ Sentinel: [HIGH] Fix unit teleportation and unauthorized movement#98
Conversation
Added server-side ownership and adjacency checks in UnitCommandHandler.moveUnit to prevent teleportation exploits and unauthorized movement of units. Added corresponding security tests.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Unit teleportation and unauthorized movement.
π― Impact: Players could teleport units anywhere on the map or move units belonging to other players by sending manipulated commands to the server.
π§ Fix: Added server-side ownership and adjacency checks in
UnitCommandHandler.moveUnit.β Verification: Added unit tests in
src/server/game/Security.test.tscovering teleportation and unauthorized movement scenarios.PR created automatically by Jules for task 1241878146137501230 started by @b0x1