Platform 1331 httpurl - #48
Merged
Merged
Conversation
irt-shpc
force-pushed
the
PLATFORM-1331-httpurl
branch
from
July 28, 2026 15:00
ab98b26 to
9293ee7
Compare
irt-shpc
added a commit
that referenced
this pull request
Jul 28, 2026
The `t.Annotated[str, AfterValidator(validate_str_as(PydanticHttpUrl))]` construction cannot be used in `isinstance` for Python >=3.11 as it a subscripted type. In current versions of Python and Pydantic it is recommended to just use the Pydantic types unless the object absolutely requires handling as a string. That is not the case in PyHelm3 so use the Pydantic types as is. Resolves GitHub issue #48
irt-shpc
force-pushed
the
PLATFORM-1331-httpurl
branch
from
July 28, 2026 15:01
9293ee7 to
14e7c96
Compare
irt-shpc
added a commit
that referenced
this pull request
Jul 29, 2026
The `t.Annotated[str, AfterValidator(validate_str_as(PydanticHttpUrl))]` construction cannot be used in `isinstance` for Python >=3.11 as it a subscripted type. In current versions of Python and pydantic it is recommended to just use the pydantic types unless the object absolutely requires handling as a string. That is not the case in pyhelm3 so use the pydantic types as is. Furthermore the Go code in Helm only validates that icon is a valid Url according to RFC 3986 (see https://github.com/helm/helm/blob/7e641d30a9355b43a9729d04c2771215ed926899/internal/chart/v3/lint/rules/chartfile.go#L193 for the implementation). Therefore use the pydantic `AnyUrl` for the icon field. Resolves GitHub issue #48
irt-shpc
force-pushed
the
PLATFORM-1331-httpurl
branch
from
July 29, 2026 08:37
14e7c96 to
7ba2f11
Compare
The `t.Annotated[str, AfterValidator(validate_str_as(PydanticHttpUrl))]` construction cannot be used in `isinstance` for Python >=3.11 as it a subscripted type. In current versions of Python and pydantic it is recommended to just use the pydantic types unless the object absolutely requires handling as a string. That is not the case in pyhelm3 so use the pydantic types as is. Furthermore the Go code in Helm only validates that icon is a valid Url according to RFC 3986 (see https://github.com/helm/helm/blob/7e641d30a9355b43a9729d04c2771215ed926899/internal/chart/v3/lint/rules/chartfile.go#L193 for the implementation). Therefore use the pydantic `AnyUrl` for the icon field. Resolves GitHub issue #48
irt-shpc
force-pushed
the
PLATFORM-1331-httpurl
branch
from
July 29, 2026 08:40
7ba2f11 to
d9d9b3a
Compare
irt-shpc
force-pushed
the
PLATFORM-1331-httpurl
branch
from
July 29, 2026 08:42
d9d9b3a to
5105e8f
Compare
…urces Add test cases to create Chart objects from a http url and a local path (as well as the existing OCI path). Also test that a data url is loaded and handled correctly.
…pytest Pytest is quite verbose about reporting warnings that arise during testing, update packages and deprecated function calls arising from test execution.
irt-shpc
force-pushed
the
PLATFORM-1331-httpurl
branch
from
July 29, 2026 08:43
5105e8f to
53ebb5d
Compare
This was referenced Aug 3, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of subscripted annotated types breaks the
isintancecheck. Revert to using normal pydantic types.Following the Helm Go code validate the icon in metadata is a valid Url but nothing more stringent.