Expose the search repo api and implement the model - #14
Conversation
irt-shpc
left a comment
irt-shpc
left a comment
There was a problem hiding this comment.
Thanks for your contribution, sorry it took too long to be reviewed.
The confusion around capital letters was due to chart dependencies being able to have aliases that the CLI tool reports as names, they were never translated to names in deployed Kube objects. We now have a separate DependencyNameOrAlias type so I think you can drop the commit around allowing capitals.
I've posted a link to the Chart.yaml Go code so if you can rebase the branch and update the types in the model we can get this merged.
Did you have any ideas on how to test this?
| """ | ||
| Model for chart version, from search results | ||
| """ | ||
| name: NonEmptyString = Field( |
There was a problem hiding this comment.
This is the source of truth for the Chart.yaml structure https://github.com/helm/helm/blob/7e641d30a9355b43a9729d04c2771215ed926899/internal/chart/v3/metadata.go#L48 It says that the description should be an optional nonEmpty string and the chart name shouldn't have capital letters as it needs to meet the DNS rules enforced by Kubernetes objects.
2 participants
Hi, hopefully I have dont this correctly. This adds the code to expose the results from the "search repo" command so that versions can be listed.