Give the blocking driver the same coverage as the async one - #3
Merged
Conversation
Two gaps, both found by asking whether blocking was actually done. The blocking driver had no test driving a randomized backoff at all. Both drivers take any `Backoff`, and ADR001 decision 3 says they must not diverge, but the coverage had: async proved jitter and decorrelated work through the real driver and blocking proved neither. And the `Clock for &C` / `Arc<C>` impls this release adds had no in-repo test on either side. They were verified from an external crate while writing them, which is not the same as being guarded. Deleting them now fails the build with four E0599s instead of passing silently. Both drivers now carry the same three tests: jittered, decorrelated, and a borrowed-or-shared clock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.