update-ci-feature-matrix - #1
Merged
Merged
Conversation
The test job already covered all three feature combinations; docs, lint and msrv each ran only --all-features. That is not a smaller version of the same check, it is a different one: an intra-doc link can point at a feature-gated item and resolve fine under --all-features while breaking every smaller build, and clippy never looks at the code a minimal build actually compiles. This was not hypothetical. A `crate::clock::Clock` link added on the circuit-breaker branch resolved under --all-features and failed rustdoc under --no-default-features --features blocking, where `crate::clock` does not exist. Both CI and my own local gates missed it because both only ever ran the union. Verified against this branch's 0.2.0 code: all three configs pass rustdoc and clippy.
Two things I left in the first pass. `cargo check` compiles neither examples nor test targets, so the MSRV floor was only ever applied to the library. The breaker branch adds examples/breaker.rs, which today's msrv job would never look at. --all-targets covers both. And `cargo fmt --all --check` does not vary by feature, so running it inside a 3-way matrix was two wasted runs. It gets its own job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.