Repository navigation
fix(worker): pass the OS-detected app to backfilled captures - #22
Merged
Merged
Conversation
_backfill_skipped() read the app_name column to build the CaptureResult. Rows it picks up were never analyzed, so app_name is NULL and the analyzer got no OS hint. The final app name then fell back to title parsing or Gemma's visual guess (e.g. a Chrome tab became "ScreenMind"). Read detected_app first and fall back to app_name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Venopacman
marked this pull request as ready for review
October 6, 2026 09:40
Owner
|
hi @Venopacman thanks for the contribution COALESCE is overkill though. This query only hits rows with |
ayushh0110
added a commit
that referenced
this pull request
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_backfill_skipped()builds theCaptureResultfrom theapp_namecolumn. The rows it picks up were never analyzed, soapp_nameisNULL. The analyzer then has no OS hint and falls back to title parsing or Gemma's guess. Example: a Chrome tab was saved asScreenMind.Fix
One line: select
COALESCE(detected_app, app_name).Testing
New
TestAnalysisWorkerBackfillinserts a pending row withdetected_app_name="Telegram", runs_backfill_skipped()with_processmocked, and checks the hint. It fails onmain(assert None == 'Telegram') and passes with the fix.🤖 Generated with Claude Code