Skip to content

Removed registration of pgsql storage provider #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aysylu wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Removed registration of pgsql storage provider #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions go/v1beta1/storage/storagefactory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,19 +119,11 @@ func postgresStorageTypeProvider(storageType string, storageConfig *config.Stora
// RegisterDefaultStorageTypeProviders adds support for memstore, embedded and Postgres storage types
// TODO(#341) remove support for Postgres and move to a separate Register...() implementation in a separate project
func RegisterDefaultStorageTypeProviders() error {
err := RegisterStorageTypeProvider("memstore", memstoreStorageTypeProvider)
if err != nil {
return err
}

err = RegisterStorageTypeProvider("embedded", embeddedStorageTypeProvider)
if err != nil {
if err := RegisterStorageTypeProvider("memstore", memstoreStorageTypeProvider); err != nil {
return err
}

// TODO(#341) move this function invocation to a separate function within a separate project
err = RegisterStorageTypeProvider("postgres", postgresStorageTypeProvider)
if err != nil {
if err = RegisterStorageTypeProvider("embedded", embeddedStorageTypeProvider); err != nil {
return err
}

Expand Down